Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DatabaseTypeTask.php to use TypeFactory #331

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

ryanolton
Copy link
Contributor

This was updated on the 2.x branch, but I noticed a deprecation warning tonight on the 1.x branch after updating to CakePHP 4.5.0.

Cake\Database\Type is deprecated in favor of Cake\Database\TypeFactory
@codecov-commenter
Copy link

Codecov Report

Merging #331 (50c299f) into cake4 (7a793c9) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##              cake4     #331   +/-   ##
=========================================
  Coverage     87.37%   87.37%           
  Complexity     1617     1617           
=========================================
  Files           104      104           
  Lines          4633     4633           
=========================================
  Hits           4048     4048           
  Misses          585      585           
Files Coverage Δ
src/Generator/Task/DatabaseTypeTask.php 92.59% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dereuromark dereuromark merged commit 8e884f1 into dereuromark:cake4 Oct 15, 2023
8 checks passed
@ryanolton ryanolton deleted the patch-1 branch October 15, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants