Dynamically import ChartIQ #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: bug fix: babel is not using browserlist configuration # Conflicts: # package.json # yarn.lock
bruce-binary
force-pushed
the
chunk-chartiq
branch
2 times, most recently
from
f2f629f to
cb283c3
Compare
bruce-binary
force-pushed
the
chunk-chartiq
branch
from
cb283c3 to
af57eea
Compare
* dev: bug fix: newer version of react-transition-group does not have uncompressed version tweaks and upgrades unfortunately nyan reporter doesn't display nicely in travis ): Load active symbols before trading times, destroy only if not undefined, and eslint tweaks bug fix: sticky header doesn't update when clicking on filter cleanup and rolleback prev code cleanup Remove category dialog sticky header add animatioin for sticky dialog on mobile Bugfix && refactor tweak why-did-you-update Refactor Avoid react re-rendering # Conflicts: # app/index.jsx # src/store/ChartStore.js # yarn.lock
bruce-binary
force-pushed
the
chunk-chartiq
branch
from
46eddeb to
50b045b
Compare
bruce-binary
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to have SmartCharts split into multiple chunks:
Hashes are added to chunks; this ensures the chunks get updated when its contents are changed.
Some refactoring is necessary to allow ChartIQ to be loaded later on during runtime (inside
init).With this, setup instructions change: https://github.com/brucebinary/SmartCharts/tree/chunk-chartiq#quick-start
Because of breaking changes, I propose in this PR to update to
v0.3.0.