-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External SVG #552
Merged
Merged
External SVG #552
+667
−719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* dev: revert manual centering code as it does not work in variable screen widths bug fix: iOS zooms in when input is selected add edge 15 to not supported page and remove notification popup
* dev: bug fix: newer version of react-transition-group does not have uncompressed version tweaks and upgrades unfortunately nyan reporter doesn't display nicely in travis ): Load active symbols before trading times, destroy only if not undefined, and eslint tweaks bug fix: sticky header doesn't update when clicking on filter cleanup and rolleback prev code cleanup Remove category dialog sticky header bug fix: babel is not using browserlist configuration add animatioin for sticky dialog on mobile Bugfix && refactor tweak why-did-you-update Refactor Avoid react re-rendering # Conflicts: # .babelrc # yarn.lock
cb6809c
to
43c7672
Compare
43c7672
to
f87c856
Compare
* dev: ops. Accidently undid past PRs stored downloaded libraries in window so it doesn't get called again cleanup + update package.json Expose setSmartChartsPublicPath upgrade bundle analyzer cause why not chunk html2canvas chunk ResizeObserver success! Chunked out ChartIQ keep CIQ dependencies inside ChartStore only remove CIQ from app code fuse ChartIQ with SmartCharts # Conflicts: # package.json # src/store/ChartStore.js # webpack.config.js # yarn.lock
shayan-binary
approved these changes
Oct 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (Total 782Kb):
After (751.1Kb):
A 31Kb (4%) reduction in size, but the main point here being that the icons are now decoupled from the transpiled source code.
Documentation on external SVG is also added in this PR: https://github.com/brucebinary/SmartCharts/tree/external-svg#dealing-with-svgs