Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External SVG #552

Merged
merged 17 commits into from
Oct 19, 2018
Merged

External SVG #552

merged 17 commits into from
Oct 19, 2018

Conversation

bruce-binary
Copy link
Contributor

@bruce-binary bruce-binary commented Oct 17, 2018

Before (Total 782Kb):

              Asset      Size  Chunks                    Chunk Names
    smartcharts.css   121 KiB       0  [emitted]         main
     smartcharts.js   661 KiB       0  [emitted]  [big]  main

After (751.1Kb):

                                     Asset       Size  Chunks                    Chunk Names     
                           smartcharts.css   90.2 KiB       0  [emitted]         main
               sprite-7ec8sa.smartcharts.svg   83.9 KiB          [emitted]         sprite-7ec8.smartcharts
                            smartcharts.js    577 KiB       0  [emitted]  [big]  main

A 31Kb (4%) reduction in size, but the main point here being that the icons are now decoupled from the transpiled source code.

Documentation on external SVG is also added in this PR: https://github.com/brucebinary/SmartCharts/tree/external-svg#dealing-with-svgs

bruce-binary and others added 8 commits October 6, 2018 21:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* dev:
  revert manual centering code as it does not work in variable screen widths
  bug fix: iOS zooms in when input is selected
  add edge 15 to not supported page and remove notification popup
* dev:
  bug fix: newer version of react-transition-group does not have uncompressed version
  tweaks and upgrades
  unfortunately nyan reporter doesn't display nicely in travis ):
  Load active symbols before trading times, destroy only if not undefined, and eslint tweaks
  bug fix: sticky header doesn't update when clicking on filter
  cleanup and rolleback prev code
  cleanup
  Remove category dialog sticky header
  bug fix: babel is not using browserlist configuration
  add animatioin for sticky dialog on mobile
  Bugfix && refactor
  tweak why-did-you-update
  Refactor
  Avoid react re-rendering

# Conflicts:
#	.babelrc
#	yarn.lock
@bruce-binary bruce-binary force-pushed the external-svg branch 2 times, most recently from cb6809c to 43c7672 Compare October 17, 2018 09:01
@bruce-binary bruce-binary changed the title [WIP] External SVG External SVG Oct 17, 2018
bruce-binary and others added 7 commits October 18, 2018 10:58
* dev:
  ops. Accidently undid past PRs
  stored downloaded libraries in window so it doesn't get called again
  cleanup + update package.json
  Expose setSmartChartsPublicPath
  upgrade bundle analyzer cause why not
  chunk html2canvas
  chunk ResizeObserver
  success! Chunked out ChartIQ
  keep CIQ dependencies inside ChartStore only
  remove CIQ from app code
  fuse ChartIQ with SmartCharts

# Conflicts:
#	package.json
#	src/store/ChartStore.js
#	webpack.config.js
#	yarn.lock
Copy link
Contributor

@shayan-binary shayan-binary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruce-binary bruce-binary merged commit 070ecf8 into deriv-com:dev Oct 19, 2018
@bruce-binary bruce-binary deleted the external-svg branch October 19, 2018 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants