Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Use start.exe when launching a URI #595

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

Etaash-mathamsetty
Copy link
Contributor

@Etaash-mathamsetty Etaash-mathamsetty commented Aug 21, 2023

The Windows version should use start.exe as well instead of going through your web browser (wtf?)
Unfortunately, I can't test the Windows version, so that's just going to remain the same for now

@derrod
Copy link
Owner

derrod commented Aug 21, 2023

Using webbrowser.open() is admittedly a bit silly here, but on Windows it ends up just calling os.startfile() which lets the system deal with it, it was just what I knew worked at the time and didn't think about it further.

@Etaash-mathamsetty
Copy link
Contributor Author

just tested this and it works

legendary/cli.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants