Add clearCache function to ImagesLoaded

[joshhepworth]

This is related to issues I experiences that affect #103 and #92.

When using JavaScript to add images to the DOM later on with the same src attribute, simply calling imagesLoaded again will trigger immediately for these images, even if the image has not actually loaded yet.

By hooking into the event of my (or your) app that causes the addition and calling clearCache() on your ImagesLoaded instance, you can ensure that it will trigger at the appropriate time. For example, in an Ember View:

Ember.View.extend({
  imagesLoaded: null,

  addMasonry: function() {
    Ember.run.scheduleOnce('afterRender', this, function() {
      var $collection = this.$('.collection');

      $collection.masonry({ itemSelector: '.item' });

      this.set('imagesLoaded',
        new imagesLoaded($collection, function() {
          $collection.masonry();
        })
      );
    });
  }.on('didInsertElement'),

  removeMasonry: function() {
    this.$('.collection').masonry('destroy');
    // Calling clearCache here makes sure that imagesLoaded doesn't trigger too quickly when the
    // Ember View is reinserted into the DOM later on.
    this.get('imagesLoaded').clearCache();
  }.on('willDestroyElement')
});

[desandro]

Hi Josh! Thanks for digging in to this. Ember is outside my comfort zone, so I appreciate you adding your expertise.

I did cut a branch that removes the cache completely, no-cache. I'm evaluating whether its worth merging in this branch to master. It sounds like it would be useful for your use case. You wouldn't need the clearCache method at all. What do you think?

[joshhepworth]

That would also work great.

I just assumed that the cache was here to stay, and saw the issues I referenced, leading me to add the clearCache function. You can certainly just close this PR if that’s the direction you’re headed.

On Tue, Aug 19, 2014 at 5:10 PM, David DeSandro notifications@github.com
wrote:

Hi Josh! Thanks for digging in to this. Ember is outside my comfort zone, so I appreciate you adding your expertise.

I did cut a branch that removes the cache completely, no-cache. I'm evaluating whether its worth merging in this branch to master. It sounds like it would be useful for your use case. You wouldn't need the clearCache method at all. What do you think?

Reply to this email directly or view it on GitHub:
#159 (comment)

[desandro]

imagesLoaded v3.2.0 no longer uses the cache. Thank you for this contribution. It's closing time 🍊