Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for new resolver & publish #441

Merged
merged 23 commits into from
Aug 19, 2024
Merged

Conversation

m0ar
Copy link
Contributor

@m0ar m0ar commented Aug 1, 2024

Description of the Problem / Feature

  • New impl of getIndexedResearchObjects, using the new resolver routes to find streamsssss 🐃
    • It's a bit of a mess on this side as the resolver has a new human-friendly return format, but it needs to be wrangled into the subgraph lookup shape for a transitory period.
  • Fixes to all consumers of getIndexedResearchObjects 🧑‍🔧
  • New route to fetch DB node info by dPID, to match dpid's with our UUID's
  • Fix so nodes-lib returns the dPID minted by the backend from the publish call, to satisfy the new prepub requirements
  • Remove over-eager crash prevention in redisClient.ts (swallowed global exceptions without exiting, leaving stuff in a weird state sometimes) 🙅‍♂️
  • Artifacts from new state syncs of the dpid alias registry contracts

Instructions on making this work

No special setup for backend, but both frontend and resolver need these updates to support the same queries ⚠️

The new in-cluster resolver requires setting the DPID_URL_OVERRIDE envvar for the frontend to a local URL to resolve local dPID's

@m0ar m0ar added the enhancement New feature or request label Aug 1, 2024
@m0ar m0ar requested review from hubsmoke and kadamidev August 1, 2024 15:29
@m0ar m0ar self-assigned this Aug 1, 2024
@m0ar m0ar force-pushed the m0ar/new-resolver-and-publish branch 3 times, most recently from 232d70b to 4637cca Compare August 14, 2024 10:04
@m0ar m0ar force-pushed the m0ar/new-resolver-and-publish branch from ddc717d to 20e3ba4 Compare August 19, 2024 14:32
m0ar added 22 commits August 19, 2024 17:59
@m0ar m0ar force-pushed the m0ar/new-resolver-and-publish branch from 20e3ba4 to cb661e3 Compare August 19, 2024 16:11
@m0ar m0ar merged commit 882d35d into develop Aug 19, 2024
4 checks passed
@m0ar m0ar deleted the m0ar/new-resolver-and-publish branch August 19, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant