Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic repo structure #3

Merged
merged 7 commits into from
Mar 4, 2024
Merged

Basic repo structure #3

merged 7 commits into from
Mar 4, 2024

Conversation

itaihanski
Copy link
Member

@itaihanski itaihanski commented Mar 3, 2024 •
edited
Loading

Related Issues

https://github.com/descope/etc/issues/4613

Description

A basic repo including:

  • most of the general authentication functions
  • OTP authentication
  • user management
  • tenant management
  • project management
  • access key management
  • basic integration tests
  • README, LICENSE etc.

Must

  • Tests
  • Documentation (if applicable)

@itaihanski itaihanski requested a review from aviadl March 4, 2024 09:35
@itaihanski itaihanski self-assigned this Mar 4, 2024
@itaihanski itaihanski marked this pull request as ready for review March 4, 2024 09:35
@itaihanski itaihanski changed the title Basic code structure Basic repo structure Mar 4, 2024
@itaihanski itaihanski enabled auto-merge (squash) March 4, 2024 09:41
aviadl
aviadl reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@aviadl aviadl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice
Few minor comments

Descope/Internal/Authentication/Authentication.cs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Descope/Types/Types.cs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@itaihanski itaihanski requested a review from aviadl March 4, 2024 14:53
@itaihanski itaihanski merged commit ced85ba into main Mar 4, 2024
3 checks passed
@itaihanski itaihanski deleted the chore/repo-prep branch March 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aviadl aviadl aviadl approved these changes

Assignees

@itaihanski itaihanski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itaihanski @aviadl