Revert "feat: Logout previous sessions RELEASE (#846)"

This reverts commit 193b640.
descope · Nov 14, 2024 · 3c7e1fa · 3c7e1fa
1 parent dd20924
commit 3c7e1fa
Show file tree

Hide file tree

Showing 12 changed files with 100 additions and 263 deletions.
diff --git a/packages/libs/escape-markdown/project.json b/packages/libs/escape-markdown/project.json
@@ -11,15 +11,7 @@
         "push": false,
         "preset": "conventional"
       }
-    },
-    "licenseCheck": {
-			"executor": "nx:run-commands",
-			"options": {
-				"commands": [
-					"exit 0"
-				]
-			}
-		}
+    }
   },
   "tags": []
 }
diff --git a/packages/sdks/core-js-sdk/src/constants/apiPaths.ts b/packages/sdks/core-js-sdk/src/constants/apiPaths.ts
@@ -83,7 +83,6 @@ export default {
   selectTenant: '/v1/auth/tenant/select',
   logout: '/v1/auth/logout',
   logoutAll: '/v1/auth/logoutall',
-  logoutPrevious: '/v1/auth/logoutprevious',
   me: '/v1/auth/me',
   myTenants: '/v1/auth/me/tenants',
   history: '/v1/auth/me/history',

diff --git a/packages/sdks/core-js-sdk/src/sdk/flow/types.ts b/packages/sdks/core-js-sdk/src/sdk/flow/types.ts
@@ -4,5 +4,3 @@ type JSONSerializable =
   | boolean
   | null
   | Array<JSONSerializable>;
-
-  export type FlowInput = Record<string, JSONSerializable>;
diff --git a/packages/sdks/core-js-sdk/src/sdk/index.ts b/packages/sdks/core-js-sdk/src/sdk/index.ts
@@ -97,15 +97,6 @@ export default (httpClient: HttpClient) => ({
       httpClient.post(apiPaths.logoutAll, {}, { token }),
     ),
   ),
-  /**
-   * Logs out all previous sessions for the current user
-   * @param token A valid refresh token
-   */
-  logoutPrevious: withOptionalTokenValidations((token?: string) =>
-    transformResponse<never>(
-      httpClient.post(apiPaths.logoutPrevious, {}, { token }),
-    ),
-  ),
   /**
    * Returns the current user details
    * @param token A valid refresh token

diff --git a/packages/sdks/core-js-sdk/test/sdk/sdk.test.ts b/packages/sdks/core-js-sdk/test/sdk/sdk.test.ts
@@ -222,33 +222,6 @@ describe('sdk', () => {
     });
   });
 
-  describe('logoutPrevious', () => {
-    it('should throw an error when token is not a string', () => {
-      expect(() => sdk.logoutPrevious({ a: 'b' })).toThrow(
-        '"token" must be string or undefined',
-      );
-    });
-    it('should send the correct request', () => {
-      const httpRespJson = { key: 'val' };
-      const httpResponse = {
-        ok: true,
-        json: () => httpRespJson,
-        clone: () => ({
-          json: () => Promise.resolve(httpRespJson),
-        }),
-        status: 200,
-      };
-      mockHttpClient.post.mockResolvedValue(httpResponse);
-
-      sdk.logoutPrevious('token');
-      expect(mockHttpClient.post).toHaveBeenCalledWith(
-        apiPaths.logoutPrevious,
-        {},
-        { token: 'token' },
-      );
-    });
-  });
-
   describe('me', () => {
     it('should throw an error when token is not a string', () => {
       expect(() => sdk.me({ a: 'b' })).toThrow(

diff --git a/packages/sdks/react-sdk/test/hooks/useAuth.test.tsx b/packages/sdks/react-sdk/test/hooks/useAuth.test.tsx
@@ -15,7 +15,6 @@ jest.mock('@descope/web-js-sdk', () => {
   const sdk = {
     logout: jest.fn().mockName('logout'),
     logoutAll: jest.fn().mockName('logoutAll'),
-    logoutPrevious: jest.fn().mockName('logoutPrevious'),
     otp: {
       signIn: {
         email: jest.fn().mockName('otp.signIn.email'),
@@ -65,7 +64,7 @@ describe('hooks', () => {
     );
   });
 
-  it.each(['logoutAll', 'logoutPrevious', 'logout', 'otp.signIn.email'])(
+  it.each(['logoutAll', 'logout', 'otp.signIn.email'])(
     'should throw error when using sdk function before sdk initialization - %s',
     (fnName) => {
       const { result } = renderHook(() => useDescope(), {

diff --git a/packages/sdks/web-js-sdk/src/enhancers/withAutoRefresh/index.ts b/packages/sdks/web-js-sdk/src/enhancers/withAutoRefresh/index.ts
@@ -102,5 +102,5 @@ export const withAutoRefresh =
         return resp;
       };
 
-    return wrapWith(sdk, ['logout', 'logoutAll', 'logoutPrevious'], wrapper);
+    return wrapWith(sdk, ['logout', 'logoutAll'], wrapper);
   };
diff --git a/packages/sdks/web-js-sdk/src/enhancers/withLastLoggedInUser/index.ts b/packages/sdks/web-js-sdk/src/enhancers/withLastLoggedInUser/index.ts
@@ -49,7 +49,7 @@ export const withLastLoggedInUser =
     let wrappedSdk = wrapWith(sdk, ['flow.start'], startWrapper);
     wrappedSdk = wrapWith(
       wrappedSdk,
-      ['logout', 'logoutAll', 'logoutPrevious'],
+      ['logout', 'logoutAll'],
       logoutWrapper(keepLastAuthenticatedUserAfterLogout),
     );
     return Object.assign(wrappedSdk, {

diff --git a/packages/sdks/web-js-sdk/src/enhancers/withNotifications/index.ts b/packages/sdks/web-js-sdk/src/enhancers/withNotifications/index.ts
@@ -45,11 +45,7 @@ export const withNotifications =
         return resp;
       };
 
-    const wrappedSdk = wrapWith(
-      sdk,
-      ['logout', 'logoutAll', 'logoutPrevious'],
-      wrapper,
-    );
+    const wrappedSdk = wrapWith(sdk, ['logout', 'logoutAll'], wrapper);
 
     return Object.assign(wrappedSdk, {
       onSessionTokenChange: sessionPS.sub,

diff --git a/packages/sdks/web-js-sdk/src/enhancers/withPersistTokens/index.ts b/packages/sdks/web-js-sdk/src/enhancers/withPersistTokens/index.ts
@@ -62,7 +62,7 @@ export const withPersistTokens =
 
     const wrappedSdk = wrapWith(
       sdk,
-      ['logout', 'logoutAll', 'logoutPrevious'],
+      ['logout', 'logoutAll'],
       wrapper(storagePrefix),
     );
 

diff --git a/packages/sdks/web-js-sdk/test/persistTokens.test.ts b/packages/sdks/web-js-sdk/test/persistTokens.test.ts
@@ -275,19 +275,6 @@ describe('persistTokens', () => {
       expect(removeMock).toBeCalledWith('DS');
     });
 
-    it('should clear tokens on logoutPrevious even when not passing refresh token', async () => {
-      localStorage.setItem('DSR', authInfo.refreshJwt);
-      const mockFetch = jest.fn().mockReturnValue(createMockReturnValue({}));
-      global.fetch = mockFetch;
-
-      const sdk = createSdk({ projectId: 'pid', persistTokens: true });
-      await sdk.logoutPrevious();
-
-      expect(localStorage.getItem('DSR')).toBeFalsy();
-      const removeMock = Cookies.remove as jest.Mock;
-      expect(removeMock).toBeCalledWith('DS');
-    });
-
     it('should not log a warning when not running in the browser', () => {
       const warnSpy = jest.spyOn(console, 'warn');