Skip to content

Commit

Permalink
ssh: skip testHandshakeErrorHandlingN on js/wasm
Browse files Browse the repository at this point in the history
The wasm runtime cannot schedule a GC run on tight loops.
Therefore it runs out of memory if such a loop allocates memory.

Skip such a test for now.

Updates golang/go#32840

Change-Id: I922b6e02710915776d2820573fd1584a5941185b
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/184397
Run-TryBot: Agniva De Sarker <agniva.quicksilver@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Han-Wen Nienhuys <hanwen@google.com>
  • Loading branch information
desdeel2d0m authored and agnivade committed Jul 1, 2019
1 parent 971ff6c commit a4de9b9
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions ssh/handshake_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,9 @@ func TestHandshakeErrorHandlingWriteCoupled(t *testing.T) {
// handshakeTransport deadlocks, the go runtime will detect it and
// panic.
func testHandshakeErrorHandlingN(t *testing.T, readLimit, writeLimit int, coupled bool) {
if runtime.GOOS == "js" && runtime.GOARCH == "wasm" {
t.Skip("skipping on js/wasm; see golang.org/issue/32840")
}
msg := Marshal(&serviceRequestMsg{strings.Repeat("x", int(minRekeyThreshold)/4)})

a, b := memPipe()
Expand Down

0 comments on commit a4de9b9

Please sign in to comment.