Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eslint plugin for vuetify #708

Merged
merged 4 commits into from
Jun 20, 2023

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Mar 28, 2023

Changes

  • Add eslint plugin for vuetify
  • Lint:fix: Migrate deprecated/outdated vuetify classes

Left fixed css classes, right current.

grafik

@nils-wisiol
Copy link
Contributor

I generally like the outlines, but this leaves the style of the password change form inconsistent, see below. Similar for delete account.

I've checked other places, in particular the DNS management parts, they look fine (but no outlines).

image

Copy link
Contributor

@nils-wisiol nils-wisiol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as commented above

@peterthomassen
Copy link
Member

We don't have outlines in the DNS record editor (behind login), and we can't change that because it makes heavy use of combining several input fields into a row that looks like a single one. (That would break with outlines.)

So for consistency, I think we shouldn't have outlines anywhere. The absence of outlines also doesn't seem to have been a UX problem.

@nils-wisiol
Copy link
Contributor

nils-wisiol commented Jun 10, 2023 via email

@peterthomassen
Copy link
Member

sure, I don't feel strongly.

@Rotzbua Rotzbua requested a review from nils-wisiol June 12, 2023 13:15
Copy link
Member

@peterthomassen peterthomassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, rebased and bumped eslint-plugin-vuetify version (old version needed for old Vuetify)

@peterthomassen peterthomassen merged commit 5b2121f into desec-io:main Jun 20, 2023
@Rotzbua Rotzbua deleted the add_eslint_for_vuetify branch June 20, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants