-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add eslint plugin for vuetify #708
Conversation
ddac704
to
daca503
Compare
daca503
to
8fd209f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as commented above
We don't have outlines in the DNS record editor (behind login), and we can't change that because it makes heavy use of combining several input fields into a row that looks like a single one. (That would break with outlines.) So for consistency, I think we shouldn't have outlines anywhere. The absence of outlines also doesn't seem to have been a UX problem. |
I don't think we need consistency across all forms, and I personally like the fresh look of the more prominent forms for login and registration. Just as a chance. I agree that the DNS management can't and shouldn't use outlines and merely meant that it should be consistent within the password change and delete account form.
|
sure, I don't feel strongly. |
3b063a6
to
867c922
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, rebased and bumped eslint-plugin-vuetify version (old version needed for old Vuetify)
Searches for deprecated attributes/properties.
867c922
to
5b2121f
Compare
Changes
Left fixed css classes, right current.