[DNM] [InMemoryDataset redesign] Object-oriented as_subchunk_map #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
changed the title
as_subchunk_map
crusaderky
changed the title
as_subchunk_map
crusaderky
commented
Sep 10, 2024
| # This causes behaviour to change if a and b have opposite signs and you try | ||
| # debugging the module in pure python, without compiling it. | ||
| # This function blindly assumes that a and b are always the same sign. | ||
| return a // b + (a % b > 0) |
There was a problem hiding this comment.
No performance difference observed
crusaderky
commented
Sep 10, 2024
|
|
||
| @cython.cclass | ||
| class EverythingMapper(IndexChunkMapper): | ||
| """Select all points along an axis [:]""" |
There was a problem hiding this comment.
Tecnically the same as SliceMapper(0, dset_size, 1, chunk_size, dset_size) but much cleaner and faster
This was referenced Sep 11, 2024
crusaderky
force-pushed
the
as_subchunk_map_oo
branch
from
7006afb
to
1731279
Compare
crusaderky
force-pushed
the
as_subchunk_map_oo
branch
2 times, most recently
from
59bb080
to
2b23449
Compare
crusaderky
commented
Sep 12, 2024
| # | ||
| # Or uncomment the -a flag above and then run: | ||
| # meson build && pushd build && meson compile && popd && firefox $(find build/ -name "*.html") | ||
|
|
There was a problem hiding this comment.
All of the above is a copy-paste from #371 - replicated here to allow for parallel review
crusaderky
force-pushed
the
as_subchunk_map_oo
branch
4 times, most recently
from
2a73d92
to
a3a2ec3
Compare
crusaderky
force-pushed
the
as_subchunk_map_oo
branch
from
a3a2ec3
to
efecb3e
Compare
crusaderky
force-pushed
the
as_subchunk_map_oo
branch
from
efecb3e
to
f7f09fc
Compare
crusaderky
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial PR that breaks down #370 into digestible chunks - see #370 (comment)
This PR refactors
as_chunk_submapto be built on top of an abstract class,IndexChunkMapper, which is then implemented by one subclass per type of index.This in and by itself is hardly useful, but it will become necessary when these mapper objects will be used all over the place by #370.
There are also a few extra features, which are unused for now:
IndexChunkMapper.chunk_submap, which refactors the existing code, can nowas_subchunk_map.These new features remain untested for now; unit tests will be added in #373.