Skip to content

Commit

Permalink
More format changes
Browse files Browse the repository at this point in the history
  • Loading branch information
adekunleoduye committed Aug 3, 2023
1 parent 15d896a commit 5b65608
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions technical-reports/color/token-naming.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Descriptive names can be more emotional and human-friendly because they often re

| Pros | Cons |
| ------------------------------------------------------------------------------------------------------ | ----------------------------------------------------------------------------------------------------------------------------- |
| Easier for some people to identify with, could be used to distinguish brand colors from product colors | Harder to determine the scale of colors (for example: which ones are lighter vs. darker? How well do they pair together?) |
| Easier for some people to identify with, could be used to distinguish brand colors from product colors | Harder to determine the scale of colors (for example: which ones are lighter vs. darker? How well do they pair together?) |
| | Names may not be easily recognized by non-English speakers. For teams working across languages, this may not be a good choice |

<aside class="example">
Expand Down Expand Up @@ -204,11 +204,11 @@ In this case, the **$color-text-default** token is defined once, and “value”
"default": {
"$description": "Default text color",
"$value": {
"$hex": "#111111",
"$hex": "#111111"
},
"$darkValue": {
"$hex": "#ffffff"
},
}
}
}
}
Expand All @@ -232,8 +232,8 @@ In this case, the **$color-text-default** token is defined in two separate files
"default": {
"$description": "Default text color",
"$value": {
"$hex": "#111111",
},
"$hex": "#111111"
}
}
}
}
Expand All @@ -253,8 +253,8 @@ In this case, the **$color-text-default** token is defined in two separate files
"default": {
"$description": "Default text color",
"$value": {
"$hex": "#FFFFFF",
},
"$hex": "#FFFFFF"
}
}
}
}
Expand Down Expand Up @@ -299,7 +299,7 @@ export const SubbrandContext = React.createContext();

const Theme = React.forwardRef(function Theme(
{ theme = 'light', subbrand, children },
forwardedRef
forwardedRef,
) {
return (
<SubbrandContext.Provider value={subbrand}>
Expand Down

0 comments on commit 5b65608

Please sign in to comment.