Adds extensions to groups #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dtcg-tr ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pascalduez
reviewed
Mar 6, 2023
| - The keys SHOULD be chosen such that they avoid the likelihood of a naming clash with another vendor's data. The [reverse domain name notation](https://en.wikipedia.org/wiki/Reverse_domain_name_notation) is recommended for this purpose. | ||
| - Tools that process design token files MUST preserve any extension data they do not themselves understand. For example, if a group contains extension data from tool A and the file containing that data is opened by tool B, then tool B MUST include the original tool A extension data whenever it saves a new design token file containing that group. | ||
|
|
||
| Note that, since a group's `$extensions` only relate to that group, they do not have any effect on nested groups or tokens. |
There was a problem hiding this comment.
I'm wondering whether this sentence is straightforward enough.
Some parts of #106 feels a bit more explicit (too much?)
Groups
$extensionsshould not be inherited. i.e. tokens and groups within a group that has$extensionsshould not be treated as though they themselves had the same $extensions property.
github-actions bot
added a commit
that referenced
this pull request
Jul 16, 2023
SHA: 321f925 Reason: push, by valhead Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 16, 2023
SHA: 321f925 Reason: push, by valhead Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Jul 16, 2023
SHA: 321f925 Reason: push, by valhead Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106
There seems to be a consensus that allowing groups to have
$extensions(just like design tokens can), so this updates the spec accordingly.