Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Upgrade Node to v22, update deps #242

Merged
merged 6 commits into from
Aug 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,17 @@ env:
jobs:
lint:
name: Check linting issues
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/cache@v2
- uses: actions/checkout@v4
- uses: actions/cache@v4
with:
path: ~/.npm
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-node-
- uses: actions/setup-node@v3
with: { node-version: 16, cache: npm }
Copy link
Contributor Author

@drwpow drwpow Aug 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These days it’s generally safe to omit the Node version. Not only do major versions not break as often for most users anymore (unless you’re using bleeding-edge/experimental features), GitHub Actions also is pretty slow/cautious in changing the default. They’ll only use stable versions (even numbers in Node’s numbering system), and they’ll always wait several patches to make sure it’s safe.

Just using the latest Node version is not only more secure; it also tends to get faster with V8 updates.

- uses: actions/setup-node@v4
with:
cache: npm
- run: npm ci
- run: npm run lint
4 changes: 2 additions & 2 deletions .github/workflows/technical-reports.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
main:
name: Build and deploy technical reports
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
strategy:
max-parallel: 1
matrix:
Expand All @@ -20,7 +20,7 @@ jobs:
- source: technical-reports/color/index.html
destination: color/index.html
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- uses: w3c/spec-prod@v2
with:
TOOLCHAIN: respec
Expand Down
3 changes: 0 additions & 3 deletions .husky/pre-commit
Original file line number Diff line number Diff line change
@@ -1,4 +1 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npx lint-staged
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v16.8.0
v22
2 changes: 1 addition & 1 deletion netlify.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# For previews, we publish an unbuilt version of the website
[build]
publish = "technical-reports/"
command = "npm run build"
command = "npx puppeteer browsers install chrome && npm run build"
[build.processing]
skip_processing = false
[build.processing.css]
Expand Down
Loading
Loading