Update GitHub Actions #243
Conversation
✅ Deploy Preview for dtcg-tr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| with: | ||
| path: ~/.npm | ||
| key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-node- | ||
| - uses: actions/setup-node@v3 | ||
| with: { node-version: 16, cache: npm } |
There was a problem hiding this comment.
Note: removing node-version outright should be fine; we just get the latest, when it updates. Back in the days of 10.x/12.x/14.x/16.x, changes were sweeping, and significant. Nowadays the major versions probably won’t break anything (this repo relies on fairly-minimal stuff)
There was a problem hiding this comment.
Whoa using a newer version of Node in GitHub Actions (and newer actions) sped it up by quite a bit! The newer version completed before the old version did (and the old version got a head start, too!)
|
On second thought, closing. #242, when we update versions, fails in GitHub Actions. Better to do both at once. |
Changes
Updates GitHub Action runners to the current version. No other changes.
Reviewing