-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for collecting metrics from nginx and php-fpm #49
base: main
Are you sure you want to change the base?
Conversation
fcoelho
commented
Jul 18, 2024
•
edited
Loading
edited
07ed5ea
to
ae5ae7c
Compare
"http://localhost:10001/fpm/dp_broadcaster/status?openmetrics", | ||
"http://localhost:10001/fpm/dp_gql/status?openmetrics", | ||
"http://localhost:10001/fpm/dp_internal/status?openmetrics", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you are relying on the backlog count to be accurate here but AFAIK, the backlog count always returns 0 (https://bugs.php.net/bug.php?id=80739) - or at least it certainly did up until PHP 8.1.
I've had to use this command in a loop if I actively wanted to monitor the backlog status: ss -ln | grep "/run/php_fpm_dp" | grep -v status | awk '{print "["$3"]: "$5}'
[0]: /run/php_fpm_dp_default.sock
[0]: /run/php_fpm_dp_internal.sock
[0]: /run/php_fpm_dp_gql.sock
[0]: /run/php_fpm_dp_broadcaster.sock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wasn't aware of that, thanks
the metrics I have immediate use for are mostly the number of active/idle/total processes (even though it seems like this number may not be always accurate: php/php-src#14212)
|
||
{{if getenv "METRICS_ENABLED" "false"}} | ||
[sinks.metrics_prometheus_exporter] | ||
type = "prometheus_exporter" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need more options here? i.e. address, auth, etc.