Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate updating the embedded Git details #219

Merged
merged 9 commits into from
Sep 26, 2018
Merged

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Sep 26, 2018

Following on from desktop/dugite-native#115, this PR makes it a one-liner to update the embedded Git in dugite to the latest release of dugite-native.

npm run update-embedded-git

This required moving a bit of the internals around:

  • introduce a script/embedded-git.json JSON object that we use when installing or updating dugite, rather than our previous hard-coded logic
  • use a consistent ${process.platform}-${os.arch()} convention for resolving versions (like before, if we don't have a version that matches here, we skip the download step).

And because the Git and Git LFS versions have updated recently, we've updated the test/helpers.ts file to these new versions.

@shiftkey
Copy link
Member Author

@outofambit @iAmWillShepherd I'd love a sanity check that these changes make sense for y'all

Copy link
Contributor

@outofambit outofambit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me!, just one question

@shiftkey shiftkey merged commit d8957ac into master Sep 26, 2018
@shiftkey shiftkey deleted the automate-updating-config branch September 26, 2018 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants