Add N-API support #217
Merged
Add N-API support #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiou87
commented
Apr 15, 2021
| } | ||
| else if (wcscmp(valueType, L"REG_DWORD") == 0) | ||
| { | ||
| uint32_t dwordData = info[4].ToNumber().Uint32Value(); |
There was a problem hiding this comment.
This is the only change I made with respect the original behavior: we were using int, but DWORD is an unsigned integer of 32bits, so using uint32_t is much more correct.
sergiou87
force-pushed
the
switch-to-n-api
branch
from
2fc4bbc
to
d0e09b1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update registry.js to support N-API. I basically ran the conversion tool and made changes on top of that.
The bulk of the work was about changing part of the syntax, and removing references to V8 in favor of the new N-API replacements.
I also found we were using the wrong type for
DWORDvalues, which could cause issues with high values.