Remove all the legacy handlers #566
Assignees
Labels
kind/enhancement
Enhance an already existing feature; no "New feature" to add
x/posts
Post module
x/profiles
Module that allows to create and manage decentralized social profiles
x/subspaces
Issue on the x/subspaces module
Comments
dadamu
added
kind/new-feature
mergify bot
pushed a commit
that referenced
this issue
Mar 24, 2022
## Description Closes: #566 This PR removes all legacy handlers since it is no longer used. See: cosmos/cosmos-sdk#7517 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [ ] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature description
After removing the legacy REST endpoints, the handlers could be removed as well, like what cosmos team is doing.
Implementation proposal
Remove all the
handler.goandNewHandler(), then setRoute()returns empty sdk.Route or panic alerts in all the modules.The text was updated successfully, but these errors were encountered: