Ln/twitch embed #468
Ln/twitch embed #468
Conversation
…dd tests, close embed url input after submitting post
| expect(EmbedUrlParserService.isValidTwitchEmbedURL(res)).toBeFalsy(); | ||
| }); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Is this...a...frontend test??? 😱
| } | ||
| } | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This is one hell of a regex... seems legit as far as I can tell though, given all the character sets are restricted to basic characters. Nice work!
|
In the create post component, it's not clear that you can add Twitch URLs. We're running out of space in the placeholder text but it would be nice to communicate this somehow: |
I was thinking icons would be a good way to communicate for which services we support embeds. However, each service has its own set of design guidelines to which we'll need to adhere and I don't want to block enabling Twitch embeds to get that all squared away. For example, some design guidelines state that a different logo must be used if on a black background vs. white, so we'll have to adjust which icon we use depending on the active theme. For now, I'll decrease the font-size and add Twitch to the end. That work for you? @redpartyhat
|
No description provided.