Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Delete PII button on settings page #495

Merged
merged 2 commits into from
Nov 9, 2021
Merged

add Delete PII button on settings page #495

merged 2 commits into from
Nov 9, 2021

Conversation

lazynina
Copy link
Member

image

image

@lazynina lazynina requested a review from a team as a code owner October 19, 2021 17:17
@maebeam
Copy link
Contributor

maebeam commented Oct 20, 2021

Can we make the button red and say "Delete personal information"? Not sure if most people know what PII is

@lazynina
Copy link
Member Author

lazynina commented Nov 4, 2021

Can we make the button red and say "Delete personal information"? Not sure if most people know what PII is

yep! Makes sense. See changes made here

image

image

@lazynina lazynina merged commit 1279bfd into main Nov 9, 2021
@lazynina lazynina deleted the ln/delete-pii branch November 9, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maebeam maebeam maebeam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lazynina @maebeam