remove the empty function

[Srijan25]

correct this click code

remove the empty constructor

[deepsource-io]

Here's the code health analysis summary for commits ff6fe9f..7150530. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
JavaScript	✅ Success	🎯 5 occurences resolved	View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

[nmarulo]

@Srijan25
I have left you a comment in the src/app/modules/shopping-list/pages/add-products-shopping-list/add-products-shopping-list.component.ts file. Regarding the other two changes, which deepsource issues refer to these two file changes?

If they are not related to an issue, they do not need to be made in this issue. That refactoring can be left for another issue. Anyway, as it is already done, we leave it as it is.

[Srijan25]

yeah sorry i didn't realise it was stuck in infinite loop i fixed it

[Srijan25]

yeah i remove that logic because i think its unnecessary

[Srijan25]

resolved

[Srijan25]

can you check once

[nmarulo]

Check if you have uploaded all the changes and test it before, please.

[nmarulo]

Read the recommendations given by deepsource, I believe that in this case it is ok to do so and there is no need to replace or delete it.

https://app.deepsource.com/gh/despensa-app/despensa-web/issue/JS-0321/occurrences?listindex=0

For example in this PR #19, although I do not accept it for another reason, the solution is also valid for me.

Sometimes the solution may be simpler than you think.