Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rest-api breaking when metric_name has colons #96 #130

Merged
merged 1 commit into from
May 1, 2020
Merged

Fix rest-api breaking when metric_name has colons #96 #130

merged 1 commit into from
May 1, 2020

Conversation

nicknagi
Copy link
Contributor

@nicknagi nicknagi commented Apr 29, 2020 •
edited
Loading

Straightforward change, added a unit test as well.

Additional Explanation: #96 (comment)

@nicknagi nicknagi requested a review from shazraz April 29, 2020 20:46
@nicknagi nicknagi linked an issue Apr 29, 2020 that may be closed by this pull request
[BUG] Putting colons in metric/parameter/tag keys breaks the REST API #96
Closed
@kyledef kyledef self-requested a review May 1, 2020 14:13
@nicknagi nicknagi merged commit 00054e1 into master May 1, 2020
@nicknagi nicknagi deleted the nn-rest-api-fix branch May 1, 2020 14:39
@mohammedri mohammedri mentioned this pull request May 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyledef kyledef kyledef approved these changes

@shazraz shazraz Awaiting requested review from shazraz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Putting colons in metric/parameter/tag keys breaks the REST API
2 participants
@nicknagi @kyledef