Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

value bug and quick ui to CardInfo #33

Merged
merged 1 commit into from
Jan 22, 2025
Merged

value bug and quick ui to CardInfo #33

merged 1 commit into from
Jan 22, 2025

Conversation

destinio
Copy link
Owner

This pull request includes several changes to the CardInfo and PricesChart components, as well as some import optimizations in the List page. The most important changes include the addition of a new icon for the close button, the calculation of the card value, and the removal of the YAxis from the PricesChart.

Enhancements to CardInfo component:

  • Added the FaX icon from react-icons for the close button in CardInfo component.
  • Introduced a new variable value to calculate the difference between pricePaid and marketPrice in CardInfo component.

Changes to PricesChart component:

  • Removed the YAxis from the PricesChart component to simplify the chart display.

Import optimizations:

  • Reordered and optimized imports in the List page to remove unused imports and improve readability. [1] [2]

@destinio destinio merged commit c3c96cb into main Jan 22, 2025
1 check passed
@destinio destinio deleted the morning-fixes-1-22 branch January 22, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant