Add NotLoggedIfNull attribute #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: - NotLoggedIfDefaultAttribute - Unit Tests
PR description suggestion Co-Authored-By: Ivan Maximov <sungam3r@yandex.ru>
- Add Type to IPropertyDestructuringAttribute.TryCreateLogEventProperty - Change all IPropertyDestructuringAttribute implementations to include type - Change NotLoggedIfDefaultAttribute (Include cache) - Write Unit Tests
Ignore null properties can be globally applied without applying attributes: `Destructurama.Attributed.AttributedDestructuringPolicy.IgnoreNullProperties = true;`
sungam3r
reviewed
Dec 17, 2020
src/Destructurama.Attributed/Attributed/IPropertyDestructuringAttribute.cs
Outdated
Show resolved
Hide resolved
sungam3r
reviewed
Dec 17, 2020
sungam3r
reviewed
Dec 17, 2020
|
Related to #18 |
|
@sungam3r Any update on this, please? |
|
I'm neither an owner of this repo nor have write access to be able to merge PRs. |
|
@SimonCropp Is it possible to have an update on this, please? |
|
@heman-dookhee-cko Thanks for PR. Now I'm a member of destructurama org so please resolve conflicts and I'll review/merge. |
# Conflicts: # README.md # src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs # src/Destructurama.Attributed/Attributed/LogMaskedAttribute.cs # src/Destructurama.Attributed/LoggerConfigurationAttributedExtensions.cs # test/Destructurama.Attributed.Tests/MaskedAttributeTests.cs
|
@sungam3r conflicts resolved, please review/merge |
sungam3r
reviewed
Jan 16, 2024
sungam3r
reviewed
Jan 16, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicyOptions.cs
Outdated
Show resolved
Hide resolved
…gPolicyOptions.cs
sungam3r
reviewed
Jan 16, 2024
|
OK, will review soon. I was busy updating other 2 repos in destructurama org. |
sungam3r
reviewed
Jan 21, 2024
src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicyOptions.cs
Outdated
Show resolved
Hide resolved
…gPolicyOptions.cs
sungam3r
reviewed
Jan 21, 2024
|
@avtc Thanks. Will be published coming days. |
This was referenced Jan 21, 2024
|
@sungam3r can this be causing a memory leak? |
|
Please open issue if so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
NotLoggedIfNullAttributeand testsIt has effect only on reference types and nullables.
Ignore null properties can be globally applied without applying attributes:
Based on PR: #38