Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MetadataTypeAttribute #91

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Support for MetadataTypeAttribute #91

wants to merge 8 commits into from

Conversation

sungam3r
Copy link
Member

see #40

@github-actions github-actions bot added the tests Pull request that adds new or changes existing tests label Jan 23, 2024
@sungam3r sungam3r added the enhancement New feature or request label Jan 23, 2024
# Conflicts:
#	src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
@sungam3r sungam3r added the help wanted Extra attention is needed label Feb 27, 2024
Copy link

This pull request was marked as stale since it has not been active for a long time

@github-actions github-actions bot added the stale label Apr 10, 2024
@github-actions github-actions bot closed this Jun 9, 2024
@sungam3r sungam3r reopened this Dec 12, 2024
@sungam3r sungam3r removed the stale label Dec 12, 2024
@digitalsigi
Copy link

Hi,

first findings: MetadataAttribute is not supported on NETSTANDARD <= 2.0. So I'll implement it only for 2.1. See here and the links to github https://stackoverflow.com/a/45464204/1889267

I'll possibly have to create a separate testproject for metadataattribute Test and target only the Net Standard 2.1 library. Is this OK for you?

@digitalsigi
Copy link

Hi,

was able to implement a solution without new test project. However, for some reason I could not push it to this repo. It also looks like that my fork from original project is quite different from this code. How to handle that/go ahead?

@sungam3r
Copy link
Member Author

However, for some reason I could not push it to this repo

Of course, you have no access to this repo. Fork it, make changes and create PR into this repo from your repo.

@digitalsigi
Copy link

digitalsigi commented Dec 16, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed tests Pull request that adds new or changes existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants