-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MetadataTypeAttribute #91
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # src/Destructurama.Attributed/Attributed/AttributedDestructuringPolicy.cs
This pull request was marked as stale since it has not been active for a long time |
Hi, first findings: MetadataAttribute is not supported on NETSTANDARD <= 2.0. So I'll implement it only for 2.1. See here and the links to github https://stackoverflow.com/a/45464204/1889267 I'll possibly have to create a separate testproject for metadataattribute Test and target only the Net Standard 2.1 library. Is this OK for you? |
Hi, was able to implement a solution without new test project. However, for some reason I could not push it to this repo. It also looks like that my fork from original project is quite different from this code. How to handle that/go ahead? |
Of course, you have no access to this repo. Fork it, make changes and create PR into this repo from your repo. |
Ok, my fault and misunderstanding. Will do that.
Am 16.12.2024 um 19:33 schrieb Ivan Maximov ***@***.***>:
However, for some reason I could not push it to this repo
Of course, you have no access to this repo. Fork it, make changes and create PR into this repo from your repo.
—
Reply to this email directly, view it on GitHub<#91 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGQGKPFPDFB6Y3M2NFDDRL2F4MH5AVCNFSM6AAAAABTPBAJ3SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBWGM2TMNZYGI>.
You are receiving this because you commented.Message ID: ***@***.***>
|
see #40