Support native targets #6
Conversation
* Update gradle to 7.3.3 * Update kotlin to 1.6.10 * Introduce KMP project layout
| kotlin("plugin.serialization") version "1.7.20" | ||
| id("org.jetbrains.dokka") version "1.7.20" |
There was a problem hiding this comment.
Dokka setup looks good. javadoc-silence.txt is not necessary although Dokka is quite noisy.
build.gradle.kts
Outdated
| `maven-publish` | ||
| signing | ||
| kotlin("jvm") version "1.7.20" | ||
| kotlin("multiplatform") version "1.7.20" |
There was a problem hiding this comment.
Note: this will download about 500MB extra on each CI, and additionally requires 2GB of permanent disk space on local machines.
There was a problem hiding this comment.
additionally requires 2GB of permanent disk space on local machines. I think we have gradle caches so it is not a net new addition if the dev machine already compiles kotlin multiplatform?
There was a problem hiding this comment.
if the dev machine already compiles kotlin multiplatform
That's why I noticed it, this is the first KMP build I did.
we have gradle caches
I don't think ~/.konan is part of Gradle caches, it seems that Kotlin Native doesn't use the traditional Gradle features to download stuff. Anyway, not much we can do if we want to accept this build feature.
build.gradle.kts
Outdated
| `maven-publish` | ||
| signing | ||
| kotlin("jvm") version "1.7.20" | ||
| kotlin("multiplatform") version "1.7.20" |
There was a problem hiding this comment.
additionally requires 2GB of permanent disk space on local machines. I think we have gradle caches so it is not a net new addition if the dev machine already compiles kotlin multiplatform?
|
Waiting for @TWiStErRob for a final look |
There was a problem hiding this comment.
I think I'm good, except a nit to silence the build output for something that's not actionable.
# Conflicts: # build.gradle.kts
|
I updated with latest |
|
Thank you for the contrib, @nulls! Great to see these kinds of improvements. I also just noticed that you work for the competition :) |
|
thank you guys for making this library! Only one thing is remaining: to release this change to the Central, yes? |
|
I will do it tomorrow |
Supported: jvm, linuxX64, mingwX64 and macosX64
It closes #5