Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node version to active LTS (DET-7046) #3932

Merged
merged 8 commits into from
Apr 26, 2022

Conversation

johnkim-det
Copy link
Contributor

@johnkim-det johnkim-det commented Apr 18, 2022

Description

Updating node from v12.14 to v16.14.2
Screen Shot 2022-04-18 at 3 47 22 PM

Also updating npm version to latest, v8.7.

Test Plan

should not require additional testing as long as everything builds and regression tests pass

Commentary (optional)

Updating from npm v8.5 to v8.7 requires one of two solutions:

Checklist

  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 18, 2022
@netlify
Copy link

netlify bot commented Apr 18, 2022

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 18c6bb5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6261bc1c2459280008619f38
😎 Deploy Preview https://deploy-preview-3932--determined-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@johnkim-det johnkim-det changed the title WIP Det 7046 chore: update node version to active LTS version Apr 18, 2022
@johnkim-det johnkim-det changed the title chore: update node version to active LTS version chore: update node version to active LTS (DET-7046) Apr 18, 2022
@johnkim-det johnkim-det requested a review from hamidzr April 18, 2022 21:11
@hamidzr hamidzr self-assigned this Apr 18, 2022
Copy link
Contributor

@hamidzr hamidzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments but overall LGTM.

If we go with the legacy npm config option, it'd be good to see when we can take the added option out.
From a search I did previously it looked like we should be able to get rid of it once react-scripts & CRA release new versions and craco adopts them

https://github.com/gsoft-inc/craco/releases/tag/v7.0.0-alpha.0

CONTRIBUTING.md Outdated Show resolved Hide resolved
"node": "^14.16.0",
"npm": "<7.0.0"
"node": "^16.14.2",
"npm": "^8.7.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: match CONTRIBUTING.md ?

@@ -0,0 +1 @@
legacy-peer-deps=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be ideal to see if we can upgrade our packages so we don't need this but it sounds like this is a good step forward and strictly a win.

https://github.blog/2021-02-02-npm-7-is-now-generally-available/#peer-dependencies

You have the option to retry with --force to bypass the conflict or --legacy-peer-deps command to ignore peer dependencies entirely (this behavior is similar to versions 4-6).

@hamidzr
Copy link
Contributor

hamidzr commented Apr 18, 2022

could you also please check that storybooks builds (dev & production) are not affected?

@hamidzr hamidzr assigned johnkim-det and unassigned hamidzr Apr 18, 2022
@johnkim-det
Copy link
Contributor Author

i think we need legacy-peer-deps to address a peer dependency error that shows up with the storybook build anyway, so i'm going to stick with using that for now, instead of the fork. not sure if there's anything we can do on our end about the storybook issue.

@johnkim-det johnkim-det merged commit 59796b0 into determined-ai:master Apr 26, 2022
@dannysauer dannysauer modified the milestones: 0.0.102, 0.18.0 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants