Kk/naming fix #293
Merged
Kk/naming fix #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The enforced camel casing breaks existing standard names like `ERC20.sol` and make the typings look like `Erc20.d.ts`, which adds complexity and confusion and requires unnecessary work to use typechain@2.0.
Don't enforce camel case
quezak
reviewed
Oct 29, 2020
| const t2 = t1.replace(/^\d+/, '') // removes leading digits | ||
| const result = upperFirst(camelCase(t2)) | ||
| const transformations: ((s: string) => string)[] = [ | ||
| (s) => s.split(' ').join('-'), // spaces to - so later we can automatically convert them |
There was a problem hiding this comment.
isn't it prettier with a replace? 😃 also takes care of sequences of multiple and different whitespace chars
Suggested change
| (s) => s.split(' ').join('-'), // spaces to - so later we can automatically convert them | |
| (s) => s.replace(/\s+/g, '-'), // spaces to - so later we can automatically convert them |
Comment on lines
8
to
12
| (s) => s.split(' ').join('-'), // spaces to - so later we can automatically convert them | ||
| (s) => s.replace(/^\d+/, ''), // removes leading digits | ||
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '-'), | ||
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '_'), | ||
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '.'), |
There was a problem hiding this comment.
another idea: replace all non-word char sequences with a single '-' in one go, so you don't have to repeat the bottom lines:
Suggested change
| (s) => s.split(' ').join('-'), // spaces to - so later we can automatically convert them | |
| (s) => s.replace(/^\d+/, ''), // removes leading digits | |
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '-'), | |
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '_'), | |
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '.'), | |
| (s) => s.replace(/\W+/g, '-'), // replace non-word character sequences with a single '-' | |
| (s) => s.replace(/^\d+/, ''), // removes leading digits | |
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '-'), |
There was a problem hiding this comment.
... and yet another option without the need for a helper function :D
Suggested change
| (s) => s.split(' ').join('-'), // spaces to - so later we can automatically convert them | |
| (s) => s.replace(/^\d+/, ''), // removes leading digits | |
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '-'), | |
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '_'), | |
| (s) => deleteCharacterAndCaptializeNextCharacter(s, '.'), | |
| (s) => s.replace(/^\d+/, ''), // remove leading digits | |
| (s) => s.replace(/\W+/g, '-'), // replace non-word character sequences with a single '-' | |
| (s) => s.replace(/-[a-z]/g, match => match.substr(-1).toUpperCase()), // delete '-' and capitalize the letter after them | |
| (s) => s.replace(/-/g, ''), // remove remaining minuses |
quezak
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.