Clean up method receiver constructors #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the `NewReceiver` method and moves logic for the `Define` method from the `Engine` method receiver to `Context`. Moving the `Define` method was required due to a bug/feature where destroying a `Context` before all defined Receivers have also been destroyed causes memory errors. Tying method receiver definitions to the `Context` lifecycle implicitly fixes this issue. This approach, however, contains a possible flaw, since class names in PHP are defined in the global scope (i.e. the `Engine`), and destroying a defined `Receiver` also removes the class entry for that name, supposedly across all running contexts.
deuill
force-pushed
the
feature/dependency-cleanup
branch
from
2a410da to
c1905f3
Compare
deuill
added a commit
that referenced
this pull request
Feb 19, 2016
Clean up method receiver constructors
borancar
pushed a commit
to borancar/go-php
that referenced
this pull request
Dec 1, 2019
Feature/resource group param Approved-by: James Stow <james.stow@antstream.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes duplicate constructors for Context and Receiver method receivers, enforcing instantiation through the canonical Engine methods.