Add the ability to skip SSL verification #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2023 22:06
This adds a key into the config that results in SSL connections not being verified.
Run all tests inside container environment for consistency. Add a script to do so and add a note inside the readme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a key into the config that results in SSL connections not being verified.
To test this required creating an Arango instance with an invalid SSL certificate, so introduces another service into the
docker-compose.ymlfile.I've added the facility to run all the tests inside Docker, both locally and in CI. In the
perform_test.gofile it is easy to switch between a local and containerised Arango endpoint with an environment variable; in the tests using the YAML config file I've just had to change the values in there, which is of course controversial.Let me know how you feel about these wider changes - I use the Remote Containers plugin in VSCode so this works really well for me, but I realise that it might not suit everyone.