Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why is rsync removed? #141

Closed
duk3luk3 opened this issue Aug 7, 2017 · 3 comments
Closed

Why is rsync removed? #141

duk3luk3 opened this issue Aug 7, 2017 · 3 comments
Labels
bug

Comments

@duk3luk3
Copy link
Contributor

duk3luk3 commented Aug 7, 2017 •
edited
Loading

Commit 0bba152 changes the package removal list from hardcoded to based on the os_security_packages_list variable and at the same time adds rsync to the default list.

What is the rationale for removing the rsync package? Was this an oversight? It is not listed in the Readme packages section either...
@rndmh3ro rndmh3ro added the bug label Aug 7, 2017
@rndmh3ro
Copy link
Member

rndmh3ro commented Aug 7, 2017

Thanks for bringing this to our attention, that's not the desired behaviour.
Rsync should not be removed.

Do you want to create a PR for this?

@duk3luk3 duk3luk3 changed the title Why is resync removed? Why is rsync removed? Aug 7, 2017
duk3luk3 added a commit to duk3luk3/ansible-os-hardening that referenced this issue Aug 7, 2017
@duk3luk3
Remove rsync from package blacklist
066f423 
rsync was erroneously added to `os_security_packages_list` variable,
meaning it was uninstalled as a "package with known issues".

Fixes dev-sec#141
@duk3luk3 duk3luk3 mentioned this issue Aug 7, 2017
Merged
rndmh3ro pushed a commit that referenced this issue Aug 7, 2017
@duk3luk3
Remove rsync from package blacklist
3ccb3eb 
rsync was erroneously added to `os_security_packages_list` variable,
meaning it was uninstalled as a "package with known issues".

Fixes #141
@agateblue
Copy link

Thank you for fixing this. It seems the issue is still here at list in the 4.1.0 release, and I've be bitten by this, which in the end silently uninstalled my whole Proxmox node, as Proxmox relies on rsync.

Do you know when a release including this change will be published?

Thank you very much for your work on this role anyway, it's great :)

@rndmh3ro
Copy link
Member

@EliotBerriot, released and pushed to Ansible Galaxy!

rndmh3ro added a commit that referenced this issue Jul 24, 2020
@rndmh3ro
Merge pull request #141 from syhe/bugfix/remove-uselogin
48b5b58 
Remove deprecated UseLogin option
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
@duk3luk3
Remove rsync from package blacklist
f35bbc5 
rsync was erroneously added to `os_security_packages_list` variable,
meaning it was uninstalled as a "package with known issues".

Fixes dev-sec#141
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
@duk3luk3
Remove rsync from package blacklist
75492db 
rsync was erroneously added to `os_security_packages_list` variable,
meaning it was uninstalled as a "package with known issues".

Fixes dev-sec#141
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
@rndmh3ro
Merge pull request dev-sec#141 from syhe/bugfix/remove-uselogin
748b706 
Remove deprecated UseLogin option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duk3luk3 @agateblue @rndmh3ro