Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Role configuration. vars/main.yml? #34

Closed
ypid opened this issue Jul 27, 2015 · 5 comments
Closed

Role configuration. vars/main.yml? #34

ypid opened this issue Jul 27, 2015 · 5 comments

Comments

@ypid
Copy link
Member

ypid commented Jul 27, 2015

Hi

It seems that it is not intended/easy to change the configuration of the role via inventory variables for example or do I miss something?

What to you think about moving vars/main.yml to defaults/main.yml?
@rndmh3ro
Copy link
Member

Good catch! I'll put variables that can be overwritten by the user into the defaults-section and leave variables that aren't meant to be changed in the vars-section.

@chris-rock
Copy link
Member

+1

@chris-rock
Copy link
Member

I recommend, we do the same for ssh-hardening

@rndmh3ro
Copy link
Member

Yes, I'll do that in all roles from now on.

chris-rock added a commit that referenced this issue Jul 27, 2015
@chris-rock
Merge pull request #35 from hardening-io/separate_vars
40c2d36 
Separate system-vars from editable vars. Fix #34
@ypid
Copy link
Member Author

ypid commented Jul 27, 2015

Thanks 👍

rndmh3ro pushed a commit that referenced this issue Jul 24, 2020
@chris-rock
Merge pull request #34 from hardening-io/separate_ssh_ports
7e14a43 
Separate ssh client and server ports. Fix #33
rndmh3ro added a commit that referenced this issue Jul 24, 2020
@rndmh3ro
Merge pull request #34 from dev-sec/remove_eol_os
4cc5276 
remove eol'd OS and add new
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
@chris-rock
Merge pull request dev-sec#34 from hardening-io/separate_ssh_ports
0eaeb59 
Separate ssh client and server ports. Fix dev-sec#33
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
@rndmh3ro
Merge pull request dev-sec#34 from dev-sec/remove_eol_os
c248dc7 
remove eol'd OS and add new
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chris-rock @ypid @rndmh3ro