Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-sec CI bot should not update CHANGELOG.md in fork repository #566

Closed
addianto opened this issue Aug 24, 2022 · 4 comments · Fixed by #568
Closed

dev-sec CI bot should not update CHANGELOG.md in fork repository #566

addianto opened this issue Aug 24, 2022 · 4 comments · Fixed by #568

Comments

@addianto
Copy link
Contributor

Hello.

I noticed in my fork that dev-sec CI bot pushed a new commit to the main branch that updated CHANGELOG.md file with incorrect information. For reference, see the commit on my fork repository here: addianto@c5688d4. You can see that every links to the upstream repository are modified to point to the fork repository.

image

I suggest that the GitHub Actions workflow that update the CHANGELOG.md file to be restricted only to run on the upstream repository. So if the GitHub Actions run on fork repository, the related workflow will not run.
rndmh3ro pushed a commit that referenced this issue Aug 25, 2022
only run release actions on upstream-repo
ec330a0 
fixes #566

Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
@rndmh3ro rndmh3ro mentioned this issue Aug 25, 2022
Merged
@rndmh3ro
Copy link
Member

Good idea, please check #568

@addianto
Copy link
Contributor Author

I have checked #568. LGTM.

rndmh3ro added a commit that referenced this issue Aug 26, 2022
@rndmh3ro
only run release actions on upstream-repo (#568)
fbea75a 
fixes #566

Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>

Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
@addianto
Copy link
Contributor Author

Thanks @rndmh3ro. I have confirmed the release action does not run in my forked repository after synced the latest commit from the upstream repository. Attached is the screenshot from the Actions page of the fork repository.

image

@rndmh3ro
Copy link
Member

Glad it helped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

only run release actions on upstream-repo dev-sec/ansible-collection-hardening
2 participants
@addianto @rndmh3ro