Fix errors produced by ansible-lint #159
Conversation
zbrojny120
commented
Jan 5, 2018
zbrojny120
commented
- Removed trailing whitespace
- Fixed bare variable in tasks/yum.yml
- Handler for update-initramfs
|
There's something wrong with the syntax: |
|
Already fixed |
tasks/yum.yml
Outdated
| with_flattened: | ||
| - '/etc/yum.conf' | ||
| - '{{ yum_repos.stdout_lines| default([]) }}' | ||
| with_flattened: "{{ ['/etc/yum.conf', yum_repos.stdout_lines | default([]) ] }}" |
There was a problem hiding this comment.
I don't know about this one...
What's the advantage here? Right now, all it does for me is make it harder to parse..
There was a problem hiding this comment.
It removes ansible-lint errors related to bare variables. Do you have any other ideas how to fix this error?
There was a problem hiding this comment.
It can be "fixed" like this:
- ['/etc/yum.conf']
- '{{ yum_repos.stdout_lines| default([]) }}'
However I'm not sure if this is not maybe a bug with ansible-lint. I'll ask there.
There was a problem hiding this comment.
Ok, we will see how it goes, because I was also surprised by this error, and consider this a dirty fix.
There was a problem hiding this comment.
To go on with this PR: How about you keep the task the way it is in master and add a skip_ansible_lint tag to it? And add a comment to reference the ansible/ansible-lint#315 issue?
|
Thanks, @zbrojny120 ! |
Fix errors produced by ansible-lint
