change minimize access tasks to speed them up #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sebastian Gumprich <github@gumpri.ch>
907th
reviewed
Jan 25, 2019
tasks/minimize_access.yml
Outdated
| loop_var: outer_item | ||
| loop: | ||
| - name: find files with write-permissions for group | ||
| shell: "find {{ item }} -perm /go+w -type f" |
There was a problem hiding this comment.
There was a comment:
Using a two-pass approach for checking directories in order to support symlinks
I'm not sure how find will work with symlinked directories. I found this on StackOverflow. So may be you should use -L or -H (not sure which one) switch?
There was a problem hiding this comment.
-L seems to go up directories and -H does not (https://unix.stackexchange.com/questions/307169/what-is-the-difference-between-find-h-and-find-l-command).
There was a problem hiding this comment.
I used -L here, thanks! :)
The old link was no longer valid
Signed-off-by: Sebastian Gumprich <github@gumpri.ch>
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
change minimize access tasks to speed them up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: