Add mode to su-binary task. Fix #38 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,5 +14,5 @@ | |||
| file: dest='/etc/shadow' owner=root group=root mode=0600 | |||
|
|
|||
| - name: change su-binary to only be accessible to user and group root | |||
| file: dest='/bin/su' owner=root group=root mode | |||
| file: dest='/bin/su' owner=root group=root mode=0750 | |||
There was a problem hiding this comment.
May use YAML syntax to make such problems more obvious? E.g:
- file:
dest: '/bin/su'
owner: 'root'There was a problem hiding this comment.
I think, ansible should throw an error when a key is provided without a value. I'd rather not change the whole syntax because I like it that way.
This does throw an error. Altough we should test it correctly!;)
I'll change the tests and leave the syntax like it is.
chris-rock
added a commit
that referenced
this pull request
Sep 1, 2015
Add mode to su-binary task. Fix #38
|
Thanks @rndmh3ro |
rndmh3ro
pushed a commit
that referenced
this pull request
Jul 24, 2020
bugfix. Now option true for PrintLastLog is available again
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
bugfix. Now option true for PrintLastLog is available again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.