debian 9's nginx doesn't support tls1.3 #526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while this could be better solved by checking what nginx version is used, debian9 is eol'd in 4 months. if there will be again a need to check for nginx versions, we'll add it then Signed-off-by: rndmh3ro <github@gumpri.ch>
schurzi
reviewed
Feb 21, 2022
| @@ -23,7 +23,6 @@ nginx_add_header: | |||
|
|
|||
| nginx_set_cookie_flag: "* HttpOnly secure" | |||
| nginx_ssl_prefer_server_ciphers: "on" | |||
| nginx_ssl_protocols: "TLSv1.2 TLSv1.3" | |||
There was a problem hiding this comment.
I think, we should reverse this split, when we drop Debian 9 support. Add a Issue for future reference?
schurzi
changed the title
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
debian 9's nginx doesn't support tls1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while this could be better solved by checking what nginx version is used, debian9 is eol'd in 4 months. if there will be again a need to check for nginx versions, we'll add it then
Signed-off-by: rndmh3ro github@gumpri.ch