Ansible 2.0 support

[rndmh3ro]

This role was tested with Ansible 2.0

[rndmh3ro]

The test fails because of this new behaviour:
ansible/ansible#11964

I will take a look on how to fix this.

[rndmh3ro]

This can be merged after #63

[conorsch]

#63 is merged, so we should be good here. You could also create an additional suite: that changes the Ansible version number, so the local test-kitchen runs test against both hosts—but that would be default double the number of test runs.

Looks like Travis is defaulting to the newest release of Ansible at all times, which should give decent warning about breakage.

[rndmh3ro]

Sounds like a really good plan! I'll add that, and maybe try it with travis, too.

[chris-rock]

@rndmh3ro Should we test with Ansible 1.9 and Ansible 2.0? We could easily use multiple kitchen files. Within travis we can then prefix with KITCHEN_YAML=.kitchen.ansible19.yml b kitchen test

[chris-rock]

I also like the approach from @conorsch where we overwrite the ansible version in yml for the specific suite. +1 for that solution

[conorsch]

@chris-rock Something like this would do the trick:

diff --git a/.kitchen.yml b/.kitchen.yml                                               
index cbb76f5..889be0b 100644                                                          
--- a/.kitchen.yml                                                                     
+++ b/.kitchen.yml                                                                     
@@ -52,7 +52,16 @@ suites:                                                             
 - name: default                                                                       
   hosts: all                                                                          
   ansible_verbose: true                                                               
-  ansible_version: 1.9.2                                                              
+  ansible_version: 2.0.0.2                                                            
+  ansible_diff: true                                                                  
+  roles_path: ../ansible-os-hardening/                                                
+  provisioner:                                                                        
+    playbook: test/integration/playbooks/default.yml                                  
+                                                                                      
+- name: ansible-v1                                                                    
+  hosts: all                                                                          
+  ansible_verbose: true                                                               
+  ansible_version: 1.9.4                                                                      
   ansible_diff: true                                                                          
   roles_path: ../ansible-os-hardening/                                                        
   provisioner: 

[rndmh3ro]

Yes, I'm going to implement this. Also in travis.

[chris-rock]

@conorsch yes, this is a very good approach!

[chris-rock]

Thanks @rndmh3ro and @conorsch !