Updates "tags" parameters on includes in main.yml #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: CI tests are failing due to #63 outstanding. Once that's merged, tests will pass. |
|
@conorsch could you please rebase to master? |
Ansible v2 forbids in-line tags on include statements, and expects "tags" to be always a task-level parameter. Older versions of Ansible support both styles, so it makes sense to standardize on the latter.
|
@chris-rock Rebased to master. |
rndmh3ro
pushed a commit
that referenced
this pull request
Feb 1, 2016
Updates "tags" parameters on includes in main.yml
rndmh3ro
pushed a commit
that referenced
this pull request
Jul 24, 2020
Fixed KexAlgorithms Conditional Statement
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Fixed KexAlgorithms Conditional Statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible v2 forbids in-line tags on include statements, and expects "tags" to be always a task-level parameter. Older versions of Ansible support both styles, so it makes sense to standardize on the latter.
Here's a vim one-liner to help with this conversion (I've been doing it a lot lately):
:%s/ tags=\(\w\+\)/^M tags: \1^M/gWith a bit of manual cleanup it saves a lot of time.