Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that ssh is installed (cf #771) #774

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

Byh0ki
Copy link
Contributor

@Byh0ki Byh0ki commented Jun 24, 2024

As discussed in #771, this MR ensure that SSH is installed

@rndmh3ro
Copy link
Member

@Byh0ki, some tests fail, do you want to take a look?

@Byh0ki
Copy link
Contributor Author

Byh0ki commented Jun 27, 2024

Yes, I'll try to fix that before the end of the week.

@Byh0ki Byh0ki force-pushed the ssh-pkg-install branch from 3594a6b to 02de843 Compare June 30, 2024 07:35
@Byh0ki
Copy link
Contributor Author

Byh0ki commented Jun 30, 2024

I've modified a little bit the vars, it should fix most of the failed actions but I' not sure about the OpenBSB fail

@Byh0ki Byh0ki force-pushed the ssh-pkg-install branch from 02de843 to 5c907a2 Compare June 30, 2024 08:20
@Byh0ki
Copy link
Contributor Author

Byh0ki commented Jun 30, 2024

The specific vars were not applied, I've modified the behavior. For FreeBSD, it seems that the packages db is empty in the molecule test which we can't do much about :/

@Byh0ki Byh0ki force-pushed the ssh-pkg-install branch from 5c907a2 to 149744a Compare June 30, 2024 12:48
@Byh0ki
Copy link
Contributor Author

Byh0ki commented Jun 30, 2024

@rndmh3ro, after a few tries, everything seems to pass the tests except FreeBSD12 and OpenBSD7. I don't know these OS very well so I don't know how to fix the issue with those :/ Do you know if anyone can help on that?

@rndmh3ro
Copy link
Member

Thank you!
We'll need to check what's wrong with the BSDs.

@schurzi
Copy link
Contributor

schurzi commented Jul 2, 2024

I suspect he problem with FreeBSD 12 is that it's now out of support and the mirrors changed.
Will have to look into OpenBSD, but that one is always special ...

@schurzi
Copy link
Contributor

schurzi commented Jul 2, 2024

I created a PR to remove FreeBSD12 #777

The problem with OpenBSD is rooted in changes in this PR and need to be addressed. As far as I can find information on it OpenBSD has no separate SSH package since it is bundled with the base system. So leaving the variable ssh_pkgs empty might be an option here.

@Byh0ki
Copy link
Contributor Author

Byh0ki commented Jul 2, 2024

Seems good enough for me, I'll update the PR for OpenBSD.

@Byh0ki Byh0ki force-pushed the ssh-pkg-install branch from 149744a to 44c4b72 Compare July 2, 2024 16:16
@Byh0ki
Copy link
Contributor Author

Byh0ki commented Jul 2, 2024

Perfect, when the FreeBSD 12 PR is merged, everything will be green

Signed-off-by: Sevan Murriguian-Watrin <git@byh0ki.fr>
@Byh0ki Byh0ki force-pushed the ssh-pkg-install branch from 44c4b72 to e6edb03 Compare July 2, 2024 16:35
@rndmh3ro rndmh3ro merged commit 0233bfe into dev-sec:master Jul 2, 2024
33 checks passed
@Byh0ki Byh0ki deleted the ssh-pkg-install branch July 2, 2024 21:36
@Byh0ki
Copy link
Contributor Author

Byh0ki commented Jul 2, 2024

Nice! Thank you, do you have a plan to release a new version soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants