-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that ssh is installed (cf #771) #774
Conversation
@Byh0ki, some tests fail, do you want to take a look? |
Yes, I'll try to fix that before the end of the week. |
I've modified a little bit the vars, it should fix most of the failed actions but I' not sure about the OpenBSB fail |
The specific vars were not applied, I've modified the behavior. For FreeBSD, it seems that the packages db is empty in the molecule test which we can't do much about :/ |
@rndmh3ro, after a few tries, everything seems to pass the tests except FreeBSD12 and OpenBSD7. I don't know these OS very well so I don't know how to fix the issue with those :/ Do you know if anyone can help on that? |
Thank you! |
I suspect he problem with FreeBSD 12 is that it's now out of support and the mirrors changed. |
I created a PR to remove FreeBSD12 #777 The problem with OpenBSD is rooted in changes in this PR and need to be addressed. As far as I can find information on it OpenBSD has no separate SSH package since it is bundled with the base system. So leaving the variable |
Seems good enough for me, I'll update the PR for OpenBSD. |
Perfect, when the FreeBSD 12 PR is merged, everything will be green |
Signed-off-by: Sevan Murriguian-Watrin <git@byh0ki.fr>
Nice! Thank you, do you have a plan to release a new version soon? |
As discussed in #771, this MR ensure that SSH is installed