This repository has been archived by the owner on Dec 26, 2020. It is now read-only.
fix: Amazon linux build #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 8, 2020 16:12
Signed-off-by: Kostas <kpa@tiatechnology.com>
Signed-off-by: Kostas <kpa@tiatechnology.com>
…with major version lower than 6 Signed-off-by: Kostas <kpa@tiatechnology.com>
|
Thank you very much! :) |
|
No problem :) I have a guess about the fedora fix as well, will test it out the other day :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amazon linux is a peculiar distribution as its
os_familyisRedHat, butdistribution_major_versionis 2, which successfully met the conditional in tests and did not generateSSH keyswhich caused the role to fail validating the sshd_config against non existing files.The same condition was met in the template itself for
UsePrivilegeSeparationdirective, incorrectly setting the value and causingsshd-16inspect check to fail.This PR addresses both of these issues returning Amazon linux based build to green.