[ Chore ] Simplify tests #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review this as soon as I have 30 minutes, @mw10013! Thanks for taking the time to look again into this! The first tests were already good enough! |
|
This has been fantastic, @mw10013! Although the first approach was already really good, it had a bit of complexity added that could have made it slightly less readable than the current one. Smart choices and really great abstractions, like Not a big fan of Thank you so much for taking the time to look again into this! |
dev-xo
added a commit
that referenced
this pull request
Jan 1, 2024
* add `TOTP_STRATEGY_OPTIONS` * add `setUpFirstAuthPhase` * chore: make eslint happy --------- Author: @mw10013 Co-authored-by: Dev XO <devxo@mail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #42 [ Chore ] Simplify Tests