Improve perf on deletes when repl ident full

devansh-ism · Oct 20, 2018 · 5d6f741 · 5d6f741
1 parent 9e962ba
commit 5d6f741
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/wal2json.c b/wal2json.c
@@ -553,6 +553,13 @@ tuple_to_stringinfo(LogicalDecodingContext *ctx, TupleDesc tupdesc, HeapTuple tu
 				continue;
 		}
 
+		/* Get Datum from tuple */
+		origval = heap_getattr(tuple, natt + 1, tupdesc, &isnull);
+
+		/* Skip nulls iif printing key/identity */
+		if (isnull && replident)
+			continue;
+
 		typid = attr->atttypid;
 
 		/* Figure out type name */
@@ -563,13 +570,6 @@ tuple_to_stringinfo(LogicalDecodingContext *ctx, TupleDesc tupdesc, HeapTuple tu
 		/* Get information needed for printing values of a type */
 		getTypeOutputInfo(typid, &typoutput, &typisvarlena);
 
-		/* Get Datum from tuple */
-		origval = heap_getattr(tuple, natt + 1, tupdesc, &isnull);
-
-		/* Skip nulls iif printing key/identity */
-		if (isnull && replident)
-			continue;
-
 		/* XXX Unchanged TOAST Datum does not need to be output */
 		if (!isnull && typisvarlena && VARATT_IS_EXTERNAL_ONDISK(origval))
 		{