Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small API expansion & docs #26

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Small API expansion & docs #26

merged 4 commits into from
Jul 4, 2024

Conversation

John-Toohey
Copy link
Contributor

Hello! This is the exact same as #25, except I fixed the documentation/tests.

@John-Toohey John-Toohey changed the title Small API expansion & docs DRAFT: Small API expansion & docs Aug 28, 2022
@John-Toohey John-Toohey marked this pull request as draft August 28, 2022 13:23
@devashishdxt
Copy link
Owner

Hi. Thanks for creating this PR. I haven't reviewed the changes in detail, but on the surface, they look good. Can you mark this as Ready for review?

@John-Toohey John-Toohey marked this pull request as ready for review September 12, 2022 18:26
@John-Toohey
Copy link
Contributor Author

John-Toohey commented Sep 12, 2022 •
edited
Loading

Note I didn't manage a 'getAllKeys' function with 'offset' and 'direction' because, to be frank, I underestimated the complexity of the IndexedDB Api.

Edit: Corrected typo.

@istankovic
Copy link

@devashishdxt could you please look into this and see if it can be merged?
We have a fork of this in Wire and would like to get rid of it and go back to track the upstream closely, but we need this.

@devashishdxt
Copy link
Owner

@devashishdxt could you please look into this and see if it can be merged? We have a fork of this in Wire and would like to get rid of it and go back to track the upstream closely, but we need this.

Sure. I'll take a look over the weekend.

@devashishdxt devashishdxt changed the title DRAFT: Small API expansion & docs Small API expansion & docs Jul 3, 2024
@devashishdxt devashishdxt merged commit fd76da2 into devashishdxt:main Jul 4, 2024
@istankovic
Copy link

Thank you so much, that was really quick! 💜

istankovic added a commit to wireapp/core-crypto that referenced this pull request Jul 4, 2024
@istankovic
chore: go back to upstream rexie
0c8c968 
The upstream has just released 0.6.1 that with devashishdxt/rexie#26,
which we needed, so we can now track upstream.
@istankovic istankovic mentioned this pull request Jul 4, 2024
Merged
3 tasks
istankovic added a commit to wireapp/core-crypto that referenced this pull request Jul 4, 2024
@istankovic
chore: go back to upstream rexie
19453b4 
The upstream has just released 0.6.1 that with devashishdxt/rexie#26,
which we needed, so we can now track upstream.
istankovic added a commit to wireapp/core-crypto that referenced this pull request Jul 4, 2024
@istankovic
chore: go back to upstream rexie
b86b81c 
The upstream has just released 0.6.1 that with devashishdxt/rexie#26,
which we needed, so we can now track upstream.
istankovic added a commit to wireapp/core-crypto that referenced this pull request Jul 5, 2024
@istankovic
chore: go back to upstream rexie
805ec26 
The upstream has just released 0.6.1 that with devashishdxt/rexie#26,
which we needed, so we can now track upstream.
SimonThormeyer added a commit to wireapp/core-crypto that referenced this pull request Jul 9, 2024
@SimonThormeyer
fix: make RwLock in RustCrypto async [WPB-10044]
7a2709b 
The upstream has just released 0.6.1 that with devashishdxt/rexie#26,
which we needed, so we can now track upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devashishdxt devashishdxt devashishdxt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@John-Toohey @devashishdxt @istankovic @OtaK