Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure response is sent when assets version is invalid #12

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Ensure response is sent when assets version is invalid #12

merged 1 commit into from
Feb 18, 2020

Conversation

totaltrash
Copy link

It's not enough to put_status when halting (see https://medium.com/adorableio/halting-plugs-in-phoenix-ce674762e488 for a bit more info). I tested this in a test app and was getting a 200 instead of a 409 when the assets version was invalid.

tmartin8080
tmartin8080 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Collaborator

@tmartin8080 tmartin8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @totaltrash good catch!

@tmartin8080 tmartin8080 merged commit 8095d81 into devato:develop Feb 18, 2020
tmartin8080 added a commit that referenced this pull request Feb 18, 2020
@tmartin8080
Squashed commit of the following:
0ada881 
commit bea2fd5
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 19:59:53 2020 -0500

    Update readme

commit dbe8a62
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 19:59:03 2020 -0500

    Bump version

commit 8095d81
Merge: f0e6770 ca50565
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 19:58:25 2020 -0500

    Merge pull request #12 from totaltrash/develop

    Ensure response is sent when assets version is invalid

commit ca50565
Author: Darren Black <d.black@federationtraining.edu.au>
Date:   Tue Feb 18 11:33:30 2020 +1100

    Ensure response is sent when assets version is invalid

commit f0e6770
Merge: e52be47 66f69cc
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 15:09:32 2020 -0500

    Merge branch 'develop' of github.com:devato/inertia_phoenix into develop

commit e52be47
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 15:09:28 2020 -0500

    Add squash commits

commit 66f69cc
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 15:04:40 2020 -0500

    Update issue templates

commit a30dda1
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 15:03:40 2020 -0500

    Update code of conduct

commit 2311e30
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 15:03:07 2020 -0500

    Update contributing

commit 34308ad
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 15:02:12 2020 -0500

    Create CODE_OF_CONDUCT.md

commit 5d4ebfe
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 15:00:47 2020 -0500

    Update table of contents

commit 3ea743c
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 15:00:11 2020 -0500

    Add contributing link

commit ebb4aa5
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:57:45 2020 -0500

    Add contributing

commit fde0f91
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:36:50 2020 -0500

    Format changes

commit ec2a7a0
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:33:17 2020 -0500

    Update changelog

commit 6992431
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:32:03 2020 -0500

    Run credo

commit 773e38f
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:29:07 2020 -0500

    Fix license date

commit 71a990d
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:27:59 2020 -0500

    Update version

commit 324f663
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:27:08 2020 -0500

    Update readme

commit 781f2e2
Merge: ebeb6e8 6f5e247
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:22:59 2020 -0500

    Merge branch 'master' into develop

commit ebeb6e8
Merge: 72d3689 43a1316
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:22:12 2020 -0500

    Merge tag '0.1.8' into develop

    Added partial reloads

commit 72d3689
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:21:34 2020 -0500

    Bump version

commit 13f952b
Merge: 9f91904 b3da259
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:21:00 2020 -0500

    Merge pull request #11 from bigx333/feature/partial-reload

    Partial reload

commit 9f91904
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 14:18:54 2020 -0500

    Add coveralls

commit ea86780
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 13:48:42 2020 -0500

    Update action

commit b3da259
Author: Nelson Luiz Ferraz de Camargo <ncamargo@othostelecom.co.za>
Date:   Mon Feb 17 20:47:01 2020 +0200

    Implements #4 and lazy loading of props

commit e2cacdb
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 13:46:55 2020 -0500

    Test coveralls

commit b49f8f1
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 13:35:31 2020 -0500

    Update changelog

commit afb1140
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 13:35:12 2020 -0500

    Update readme

commit 84ef465
Merge: 3e3af98 34814e9
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 13:33:26 2020 -0500

    Merge tag '0.1.7' into develop

    Add inertia_layout configuration

commit 3e3af98
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 13:32:38 2020 -0500

    Bump version

commit f55b736
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 13:32:02 2020 -0500

    Add layout configuration

commit 24b4a30
Author: Troy Martin <troy@devato.com>
Date:   Mon Feb 17 12:29:15 2020 -0500

    Bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmartin8080 tmartin8080 tmartin8080 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@totaltrash @tmartin8080