Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CSRF cookie #7

Merged
merged 2 commits into from
Feb 17, 2020
Merged

Fix CSRF cookie #7

merged 2 commits into from
Feb 17, 2020

Conversation

bigx333
Copy link
Contributor

@bigx333 bigx333 commented Feb 17, 2020

By default, put_resp_cookie creates an HTTP only cookie that is not accessible on document.cookie.

tmartin8080
tmartin8080 approved these changes Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@tmartin8080 tmartin8080 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bigx333! Nice improvement

@tmartin8080 tmartin8080 merged commit eea3c30 into devato:develop Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmartin8080 tmartin8080 tmartin8080 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigx333 @tmartin8080