Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Get-NSLBVirtualServerBinding to also retrieve service_binding objects #102

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

myllyja
Copy link

@myllyja myllyja commented Jul 26, 2019

Description

Get-NSLBVirtualServerBinding was looking for lbvserver_servicegroup_binding and lbvserver_service_binding objects when called with the name parameter. Without the parameter is was only returning lbvserver_servicegroup_binding objects.

Related Issue

#101

Motivation and Context

Fixes a bug

How Has This Been Tested?

Tested by editing this file locally and running the command with and without the name parameter. It now returns both types of bindings when called without the parameter.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…bjects

Get-NSLBVirtualServerBinding was looking for lbvserver_servicegroup_binding and lbvserver_service_binding objects when called with the name parameter. Without the parameter is was only returning lbvserver_servicegroup_binding objects.
@iainbrighton
Copy link
Collaborator

Hi @myllyja thanks for the PR. Would you mind adding updating your PR with your change(s) added to the Unreleased section of the ChangeLog.md file?

@myllyja
Copy link
Author

myllyja commented Aug 21, 2019

Hi @myllyja thanks for the PR. Would you mind adding updating your PR with your change(s) added to the Unreleased section of the ChangeLog.md file?

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants