Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect-NetScaler bug #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thkn-hofa
Copy link

@thkn-hofa thkn-hofa commented Nov 16, 2020

Connect-NetScaler breaks if username or password contains certain characters (e.g.: & (ampersand))

Description

The function 'ConvertTo-JSON', which is used in 'Connect-NetScaler' converts these special characters to unicode escaped characters (e.g.: & = \u0026). This addition to the code will unescape only unicode characters.

Motivation and Context

Cannot log in when certain characters are used in username or password

How Has This Been Tested?

I could not log in with a password containing an ampersand, now I can.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant