Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #210

Merged
merged 1 commit into from
Dec 23, 2022
Merged

fix typo #210

merged 1 commit into from
Dec 23, 2022

Conversation

yf-yang
Copy link
Contributor

@yf-yang yf-yang commented Dec 20, 2022

See devcontainers/spec#160

Not sure if it was due to a typo before, see devcontainers/cli#163

@joshspicer
Copy link

Thanks for flagging! There was a small typo in the spec, which may have perpetuated this. We have now fixed this.

"installAfter" will be ignored by the devcontainers/cli tooling - installsAfter is correct 👍

Copy link
Contributor

@ebaskoro ebaskoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcbhmr
Copy link
Contributor

jcbhmr commented Dec 22, 2022

I think @danielbraun89 is on Christmas hiatus given his GitHub activity. 😭 Nobody else has merge powers.

@jcbhmr
Copy link
Contributor

jcbhmr commented Dec 22, 2022

I think this might be indirectly helping perpetuate #211 too.

@danielbraun89 danielbraun89 merged commit 00ec5c2 into devcontainers-contrib:main Dec 23, 2022
@danielbraun89
Copy link
Member

danielbraun89 commented Dec 23, 2022

@yf-yang Wow massive implications for this typo 😭 so thankful for you forr finding this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants